KTOR-2036 Fix CIO connection limit #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
force-pushed
the
e5l/fix-cio-connection-limit
branch
2 times, most recently
from
ca58c55 to
4156899
Compare
|
Please check CI |
e5l
force-pushed
the
e5l/fix-cio-connection-limit
branch
from
4156899 to
01c2830
Compare
|
@rsinukov fixed. The test was broken itself |
rsinukov
approved these changes
Aug 31, 2022
| return try { | ||
| aSocket(selector).tcpNoDelay().tcp().connect(address, configuration) | ||
| } catch (cause: Throwable) { | ||
| // a failure or cancellation | ||
| semaphore.release() | ||
| limit.release() |
There was a problem hiding this comment.
should you release addressLimit here too?
e5l
force-pushed
the
e5l/fix-cio-connection-limit
branch
from
01c2830 to
0252f21
Compare
|
@e5l any chance that the fix could be backported to 2.0.x? We are using ktor in a Gradle plugin and cannot update to 2.1.x yet because it needs Kotlin 1.7. |
|
It should be possible to use this version with old Kotlin. Could you check and file an issue if it doesn't work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KTOR-2036