KTOR-7831 Configure Gradle Daemon JDK #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
force-pushed
the
osipxd/gradle-daemon-jdk
branch
from
599afe3 to
158fc2d
Compare
osipxd
force-pushed
the
osipxd/gradle-daemon-jdk
branch
4 times, most recently
from
63a9eff to
32bb879
Compare
osipxd
force-pushed
the
osipxd/gradle-daemon-jdk
branch
3 times, most recently
from
69be986 to
8203a49
Compare
osipxd
force-pushed
the
osipxd/jdk-8-tests
branch
3 times, most recently
from
d146768 to
3537e41
Compare
osipxd
force-pushed
the
osipxd/jdk-8-tests
branch
2 times, most recently
from
dc57d34 to
67b7968
Compare
osipxd
force-pushed
the
osipxd/gradle-daemon-jdk
branch
3 times, most recently
from
b1377b4 to
d15713f
Compare
osipxd
force-pushed
the
osipxd/gradle-daemon-jdk
branch
from
d15713f to
6972bd3
Compare
osipxd
changed the title
|
JS builds should become green after e5l/ktor-test-image#3 merged and published. |
osipxd
force-pushed
the
osipxd/gradle-daemon-jdk
branch
from
6972bd3 to
9a6715e
Compare
osipxd
force-pushed
the
osipxd/gradle-daemon-jdk
branch
from
9a6715e to
92df9a1
Compare
e5l
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Infrastructure
Motivation
KTOR-7831 Use Gradle JVM toolchain for Daemon
To make builds more reproducible and independent of the environment in which they’re run.
Solution
gradle/gradle-daemon-jvm.propertiesjetty-jakartaDepends on:
The only problem is that Gradle Daemon toolchains aren’t properly supported in IDEA, so it is required to manually configure the IDEA to use JDK 21 in the "Project Structure" window:
It is better to review commit-by-commit