KTOR-7830 HttpCache may cache response before its transformation #4519
+65
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
force-pushed
the
osipxd/httpcache-after-transformations
branch
2 times, most recently
from
44d78e9 to
2cbe4a4
Compare
osipxd
force-pushed
the
osipxd/httpcache-after-transformations
branch
from
2cbe4a4 to
d86942b
Compare
bjhham
approved these changes
Dec 10, 2024
osipxd
force-pushed
the
osipxd/httpcache-after-transformations
branch
from
6bb375f to
c3cce56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client
Motivation
KTOR-7830 Installing HttpCache before ContentEncoding prevents response body to be decoded
Solution
The problem is that both
HttpCacheandContentEncodinguse phaseHttpReceivePipeline.Stateto handle responses, so installation order matters here. I've changedHttpCacheplugin to operate in an additional phase afterStatephase, when all response transformations should be already applied.