add ENDPOINT_URL environment option #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktrueda
reviewed
Mar 17, 2024
| @@ -11,7 +11,7 @@ keywords = ["parquet-tools", "parquet"] | |||
| exclude = ["parquet_tools/parquet.thrift", "parquet_tools/README.md"] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.8" | |||
| python = ">=3.9" | |||
There was a problem hiding this comment.
Could you explain why you updated this. I know Python 3.8 EOL will come soon. But I'm not sure that it's good to update python version in this PR.
There was a problem hiding this comment.
Because poetry yelled at me in your GHA, see https://github.com/ktrueda/parquet-tools/actions/runs/8312677506/job/22747801180#step:5:145
There was a problem hiding this comment.
I can revert it if you like
|
Thank you! I merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #52 as an environment variable.