Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ListBranches, add GetBranch #93

Merged
merged 2 commits into from
Jul 30, 2020
Merged

fix ListBranches, add GetBranch #93

merged 2 commits into from
Jul 30, 2020

Conversation

KshamaG
Copy link
Contributor

@KshamaG KshamaG commented Jul 27, 2020

This Pull Request has the following changes

  1. Fixes the issue with ListBranches function - ListBranches function in repository.go file is throwing error. #92
  2. Adds a method GetBranch to get a branch object within the specified repository, given the name of branch.

@KshamaG
Copy link
Contributor Author

KshamaG commented Jul 28, 2020

@ktrysmt Can you please review the PR?

ktrysmt
ktrysmt reviewed Jul 29, 2020
View reviewed changes
bitbucket.go Outdated Show resolved Hide resolved
@ktrysmt
Copy link
Owner

ktrysmt commented Jul 29, 2020

Wow, thank you very much. I left a comment on it, please. @KshamaG

@KshamaG @ktrysmt
update repo branch options query
a5dce5c 
Co-authored-by: Kotaro Yoshimatsu <kotaro.yoshimatsu@gmail.com>
@KshamaG
Copy link
Contributor Author

KshamaG commented Jul 30, 2020

@ktrysmt Thanks for your review. The review comment has been addressed. Please check.

ktrysmt
ktrysmt approved these changes Jul 30, 2020
View reviewed changes
Copy link
Owner

@ktrysmt ktrysmt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for the contribution.

@ktrysmt ktrysmt merged commit fdf03c4 into ktrysmt:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktrysmt ktrysmt ktrysmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KshamaG @ktrysmt