Add { root: true } option support to dispatch.
#6
Conversation
|
Thank you for your PR! |
|
Anytime! Using a dispatch like As a matter of fact, I'm using an I was just wondering if the actual implementation can take advantage of the same escape-from-isolation |
src/register.ts
Outdated
| if (typeof type === 'object') { | ||
| type = type.type | ||
| payload = type | ||
| } | ||
| return dispatch(localKey(type, moduleName), payload) | ||
|
|
||
| if (!options || !options.root) { |
There was a problem hiding this comment.
Can we also unify the options like commit method does? In current implementation, the options object always be 3rd argument even if the users call object style dispatch.
test/register.ts
Outdated
| actions: { | ||
| foo ({ dispatch, rootGetters }: any) { | ||
| dispatch('rootAction', 'bar', { root: true }).then(() => { | ||
| assert(rootGetters.propertyGetter() === 'bar') |
There was a problem hiding this comment.
Looks like this test is finished before executing this line. We need to use mocha's done callback here.
- Update localDispatch to support options. - Implement root option on both commit and dispatch. - Update README.md file (sentence specifying the root option).
|
Absolutely! |
|
Looks nice, thank you! |
ghost
deleted the
|
You're welcome! Thank you for your time. |
I've encountered a couple of cases where dispatching in the global namespace might become in handy.
This PR provide a way to dispatch on the global namespace by providing a
{ root: true }option as the third argument todispatch.