Add ScopedDisabled #88
Conversation
ImGui has an API that blocks interactions and visually differentiates disabled elements. While the API is technically Beta it has been around for a long time and is a big improvement over the pattern of "if (ImGui.Button(...) && buttonEnabled)"
| /// <summary> | ||
| /// Represents a scoped disabled action which will set ImGui elements as disabled until the class is disposed. | ||
| /// </summary> | ||
| public class ScopedDisabled : ScopedAction |
There was a problem hiding this comment.
How should this interact with Theme.ColorDisabled ?
There was a problem hiding this comment.
And how to even use Theme.ColorDisabled
There was a problem hiding this comment.
You're supposed to use ScopedThemeColor and pass in the enabled state, if the state is dynamic.
Theme.Color and Theme.ColorDisabled` are convenience for statically colored things (ie permanently disabled/enabled).
There was a problem hiding this comment.
I feel like this is maybe more of a ImGuiWidgets thing, like ScopedId, decouple the behavior from the presentation. The user is free to use either or both.
There was a problem hiding this comment.
No matter what I try, I haven't been able to get Theme.ColorDisabled working.
There was a problem hiding this comment.
I agree that this should go in ImGuiWidgets. Migrated and made a PR ktsu-dev/ImGuiWidgets#173
I'm still curious to figure out why I can't call ColorDisabled, but maybe I'll talk to you abbbbbbbbbbbbbbbbbt next week directly.
Remove attempts to track multiple active ScopedDisabled usages. While ScopedDisabled(true) will override ScopedDisabled(false) before the initial ScopeDisabled has been disposed, it won't actually cause a problem aside from maybe not doing what was intended (and that is really a logical flow error anyway)
Migrated from ImGuiStyler: ktsu-dev/ImGuiStyler#88
|
Closing as moved to ImGuiWidgets. |
ImGui has an API that blocks interactions and visually differentiates disabled elements. While the API is technically Beta it has been around for a long time and is a big improvement over the pattern of "if (ImGui.Button(...) && buttonEnabled)"