Enum combo #158
Merged
Enum combo #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enum in the global scope must be public which is why it has documentation :(
|
Also added IString and String combo implementations while I was there (And IString was my real use case anyway) |
Darcy3000s
reviewed
Jan 7, 2025
ImGuiWidgetsDemo/ImGuiWidgetsDemo.cs
Outdated
| private readonly Collection<StrongStringExample> possibleStrongStringValues = | ||
| [ "Strong Hello".As<StrongStringExample>(), | ||
| "Strong World".As<StrongStringExample>(), | ||
| "Strong Goodbye".As<StrongStringExample>()]; |
There was a problem hiding this comment.
Not sure what the expected convention is here, but you have an opening space for this array and not a closing space
Your other array above doesn't have a space on either side
There was a problem hiding this comment.
Yes I agree that is a bit weird. Not entirely sure what I was going for but my goal was not to have a really really long line (thanks to the casts). I've updated the code to be formatted differently that resolves this specific concern.
- Enum case simplified with less casting - Use the length of the names array instead of the possible values (even though names are created from possible values)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Combo implementation that takes an Enum type