Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ColorIndicator #159

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

Damon3000s
Copy link
Collaborator

  • Fixed several bugs -- enabled is now taken as a ref
    -- color is always popped (since deleted)
  • Added a custom rendering instead of abusing the Checkbox and changing some colors -- Some cases still not handled such as disabled (not interactive) and hover while it is active

- Fixed several bugs
-- enabled is now taken as a ref
-- color is always popped (since deleted)
- Added a custom rendering instead of abusing the Checkbox and changing some colors
-- Some cases still not handled such as disabled (not interactive) and hover while it is active
@Damon3000s
Copy link
Collaborator Author

@matt-edmondson The colour modification options in ImGuiStyler are quite extensive but I'm not sure what I should use when I want to take a defined colour and turn it into a hovered version. I tried LightenBy but that didn't really look any good.

Any recommendations or guidance?

The intention of this widget is to be non-interactive by default. Remove the click/hover logic and just display a color or framebg depending on if it is enabled
@matt-edmondson
Copy link
Contributor

@matt-edmondson The colour modification options in ImGuiStyler are quite extensive but I'm not sure what I should use when I want to take a defined colour and turn it into a hovered version. I tried LightenBy but that didn't really look any good.

Any recommendations or guidance?

We talked about this on the phone and decided that ImGuiStyler.Color.ScopedColor or ImGuiStyler.Theme.Apply() were the right place to look.

@matt-edmondson
Copy link
Contributor

And then we decided we didn't actually need any of that because the widget is intended to be non-interactive anyway.

@matt-edmondson matt-edmondson merged commit 2b43fac into ktsu-dev:main Jan 9, 2025
2 checks passed
@Damon3000s Damon3000s deleted the refactor-color-indicator-2 branch January 21, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants