Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the assert fix #162

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Simplify the assert fix #162

merged 1 commit into from
Jan 9, 2025

Conversation

Damon3000s
Copy link
Collaborator

  • Instead of creating a dummy up front and moving the cursor more times we can simply render everything as we did before and at the end move the cursor to the top right of the grid and make a dummy the height of the grid which will leave the cursor on the new line
  • This also theoretically supports ImGui.SameLine if the grid was to ever not span the full width

@Damon3000s
Simplify the assert fix
f4255b3 
- Instead of creating a dummy up front and moving the cursor more times we can simply render everything as we did before and at the end move the cursor to the top right of the grid and make a dummy the height of the grid which will leave the cursor on the new line
- This also theoretically supports ImGui.SameLine if the grid was to ever not span the full width
@matt-edmondson matt-edmondson merged commit fdae432 into ktsu-dev:main Jan 9, 2025
2 of 3 checks passed
@Damon3000s Damon3000s deleted the improve-assert-fix branch January 21, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-edmondson matt-edmondson matt-edmondson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ktsu.dev
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Damon3000s @matt-edmondson