Add tooltip support to ImGuiWidgets.Icon #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to define a Func that will return the tooltip for the Icon that applies to the Dummy created that covers the entire Icon area.
Damon3000s
commented
Jan 20, 2025
matt-edmondson
requested changes
Jan 30, 2025
- Changed how the tooltip implementation is done and migrate all optional variables into an Options class - The number of parameters and API interface was very large already so all of the optional parameters were moved into the Options struct while the required parameters were kept as direct parameters.
All members are now directly within IconOptions
Damon3000s
changed the title
matt-edmondson
requested changes
Feb 3, 2025
Change set; to init;
- Only throw for null label. Empty is technically valid - Move the Options throw into the implementation to simplify the public API body
The user should be explicit about how they want the icon to be laid out. We can't safely assume the users intent and provide a default.
matt-edmondson
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to define a Func that will return the tooltip for the Icon that applies to the Dummy created that covers the entire Icon area.