Move ScopedId to be within ImGuiWidgets class #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial implementation was not within the ImGuiWidgets class which lead to unexpected usages and inconsistencies with other classes. This is a minor API breakage to align usage with the rest of the library.
|
I have no idea how the version, changelog etc have changed but I've discarded the commit in the past. I think there might be something wrong with the scripts that are running within my fork (which has no changes to them) and I would like to discuss them to see if there are changes/improvements to be made. |
|
it probably should just not run the versioning scripts if it not main/is a fork |
This reverts commit 423984e.
matt-edmondson
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation was not within the ImGuiWidgets class which lead to unexpected usages and inconsistencies with other classes.
This is a minor API breakage to align usage with the rest of the library.