Skip to content

Commit

Permalink
pin dvc version (#1302)
Browse files Browse the repository at this point in the history
* pin dvc version

* install dvc for ci

* fix dvc install
  • Loading branch information
yehiyam authored Jun 21, 2021
1 parent f2fd2da commit 62835bd
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
10 changes: 4 additions & 6 deletions core/datasources-service/dockerfile/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ ARG BASE_PRIVATE_REGISTRY=""
FROM ${BASE_PRIVATE_REGISTRY}hkube/base-node:v1.2.1
LABEL maintainer="yehiyam@gmail.com"

RUN curl \
https://dvc.org/deb/dvc.list \
-L \
--output /etc/apt/sources.list.d/dvc.list

RUN apt update && apt install -y --no-install-recommends git dvc && rm -rf /var/lib/apt/lists/*
RUN apt update && apt install -y --no-install-recommends git && rm -rf /var/lib/apt/lists/*
RUN wget -O dvc.deb https://github.com/iterative/dvc/releases/download/2.1.0/dvc_2.1.0_amd64.deb &&\
apt install ./dvc.deb &&\
rm ./dvc.deb
ADD dockerfile/gitconfig /.gitconfig
ADD dockerfile/gitconfig /root/.gitconfig
RUN mkdir -p /hkube/datasource-service
Expand Down
2 changes: 1 addition & 1 deletion core/datasources-service/tests/update.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ describe('/datasource/:name POST', () => {
]);
expect(uploadResponse.statusCode).to.eql(StatusCodes.CREATED);
});
it.skip('should move a file', async () => {
it('should move a file', async () => {
const name = uuid();
const { body: dataSource } = await createDataSource(name);
const [existingFile] = dataSource.files;
Expand Down
5 changes: 3 additions & 2 deletions scripts/beforeInstall.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
set -ev

# install dvc and git
sudo curl https://dvc.org/deb/dvc.list -L --output /etc/apt/sources.list.d/dvc.list
sudo apt update && sudo apt install -y dvc
wget --no-verbose -O /tmp/dvc.deb https://github.com/iterative/dvc/releases/download/2.1.0/dvc_2.1.0_amd64.deb &&\
sudo apt install /tmp/dvc.deb &&\
rm /tmp/dvc.deb
git config --global user.email "hkube@hkube.io" && git config --global user.name "hkube"

# run all the required containers
Expand Down

0 comments on commit 62835bd

Please sign in to comment.