Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix datasources #1140

Merged
merged 4 commits into from
Feb 10, 2021
Merged

Bugfix datasources #1140

merged 4 commits into from
Feb 10, 2021

Conversation

reggev
Copy link
Contributor

@reggev reggev commented Feb 10, 2021

This change is Reviewable

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@reggev reggev merged commit e7fbbf2 into master Feb 10, 2021
@reggev reggev deleted the bugfix-datasources branch February 10, 2021 15:05
hkube-ci pushed a commit that referenced this pull request Feb 10, 2021
* added missing 'required' on field

* improved gitlab error handling

* improved github error handing .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Feb 10, 2021
* added missing 'required' on field

* improved gitlab error handling

* improved github error handing .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants