-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added config.template #1169
added config.template #1169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @reggev)
core/datasources-service/lib/utils/Repository.js, line 71 at r1 (raw file):
${this.dvc.cwd}/.dvc/config.template
path.join()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @yehiyam)
core/datasources-service/lib/utils/Repository.js, line 71 at r1 (raw file):
Previously, yehiyam wrote…
${this.dvc.cwd}/.dvc/config.template
path.join()
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
* added config.template * converted string template to pathLib.join .... bump version [skip ci]
* added config.template * converted string template to pathLib.join .... bump version [skip ci]
This change is