get results in webhook handler #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nassiharel
suggested changes
Mar 4, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @yehiyam)
core/api-server/lib/webhook/webhooks-handler.js, line 77 at r2 (raw file):
async _fillMissing(element) {
Need to think of different way...
yehiyam
commented
Mar 4, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @nassiharel)
core/api-server/lib/webhook/webhooks-handler.js, line 77 at r2 (raw file):
Previously, NassiHarel (Nassi Harel) wrote…
async _fillMissing(element) {Need to think of different way...
Lets open another issue to redesign the whole result saving
nassiharel
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
hkube-ci
pushed a commit
that referenced
this pull request
Mar 8, 2021
* get results in webhook handler * fix: add swagger properties Co-authored-by: NassiHarel <nassi9@gmail.com> .... bump version [skip ci]
hkube-ci
pushed a commit
that referenced
this pull request
Mar 8, 2021
* get results in webhook handler * fix: add swagger properties Co-authored-by: NassiHarel <nassi9@gmail.com> .... bump version [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is