-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reservedMemory #1197
feat: add reservedMemory #1197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nassiharel)
core/api-server/config/main/config.base.js, line 14 at r1 (raw file):
DEFAULT_ALGORITHM_RESERVED_MEMORY
DEFAULT_ALGORITHM_RESERVED_MEMORY_RATIO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nassiharel)
core/api-server/lib/service/algorithms.js, line 186 at r1 (raw file):
if (!newAlgorithm.reservedMemory) { const mem = unitsConverter.getMemoryInMi(newAlgorithm.mem); const reservedMemory = mem * this._defaultAlgorithmReservedMemory;
round to closest Mi? Even to closest 10Mi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @yehiyam)
core/api-server/config/main/config.base.js, line 14 at r1 (raw file):
Previously, yehiyam wrote…
DEFAULT_ALGORITHM_RESERVED_MEMORY
DEFAULT_ALGORITHM_RESERVED_MEMORY_RATIO?
Done.
core/api-server/lib/service/algorithms.js, line 186 at r1 (raw file):
Previously, yehiyam wrote…
round to closest Mi? Even to closest 10Mi
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yehiyam)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nassiharel)
* feat: add reservedMemory * feat: add reservedMemory * feat: add reservedMemory .... bump version [skip ci]
* feat: add reservedMemory * feat: add reservedMemory * feat: add reservedMemory .... bump version [skip ci]
This change is