Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reservedMemory #1197

Merged
merged 4 commits into from
Mar 21, 2021
Merged

feat: add reservedMemory #1197

merged 4 commits into from
Mar 21, 2021

Conversation

nassiharel
Copy link
Contributor

@nassiharel nassiharel commented Mar 18, 2021

This change is Reviewable

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nassiharel)


core/api-server/config/main/config.base.js, line 14 at r1 (raw file):

DEFAULT_ALGORITHM_RESERVED_MEMORY

DEFAULT_ALGORITHM_RESERVED_MEMORY_RATIO?

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nassiharel)


core/api-server/lib/service/algorithms.js, line 186 at r1 (raw file):

        if (!newAlgorithm.reservedMemory) {
            const mem = unitsConverter.getMemoryInMi(newAlgorithm.mem);
            const reservedMemory = mem * this._defaultAlgorithmReservedMemory;

round to closest Mi? Even to closest 10Mi

Copy link
Contributor Author

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @yehiyam)


core/api-server/config/main/config.base.js, line 14 at r1 (raw file):

Previously, yehiyam wrote…
DEFAULT_ALGORITHM_RESERVED_MEMORY

DEFAULT_ALGORITHM_RESERVED_MEMORY_RATIO?

Done.


core/api-server/lib/service/algorithms.js, line 186 at r1 (raw file):

Previously, yehiyam wrote…

round to closest Mi? Even to closest 10Mi

Done.

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yehiyam)

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nassiharel)

@nassiharel nassiharel merged commit 753bbaa into master Mar 21, 2021
@nassiharel nassiharel deleted the reserved_memory branch March 21, 2021 08:23
hkube-ci pushed a commit that referenced this pull request Mar 21, 2021
* feat: add reservedMemory

* feat: add reservedMemory

* feat: add reservedMemory .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Mar 21, 2021
* feat: add reservedMemory

* feat: add reservedMemory

* feat: add reservedMemory .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants