Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra registries #1364

Merged
merged 3 commits into from
Sep 13, 2021
Merged

add extra registries #1364

merged 3 commits into from
Sep 13, 2021

Conversation

yehiyam
Copy link
Contributor

@yehiyam yehiyam commented Aug 10, 2021

This change is Reviewable

@yehiyam
Copy link
Contributor Author

yehiyam commented Aug 10, 2021

/deploy

@yehiyam
Copy link
Contributor Author

yehiyam commented Aug 10, 2021

/deploy

@hkube-ci hkube-ci temporarily deployed to dev August 10, 2021 12:18 Inactive
@yehiyam yehiyam marked this pull request as draft August 11, 2021 08:54
@yehiyam yehiyam marked this pull request as ready for review September 13, 2021 06:20
@yehiyam yehiyam requested a review from nassiharel September 13, 2021 07:52
Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yehiyam)

@yehiyam yehiyam merged commit 9d92e51 into master Sep 13, 2021
@yehiyam yehiyam deleted the push-to-ghcr branch September 13, 2021 13:07
hkube-ci pushed a commit that referenced this pull request Sep 13, 2021
* add extra registries

* fix ci .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Sep 13, 2021
* add extra registries

* fix ci .... bump version [skip ci]
golanha pushed a commit that referenced this pull request Sep 12, 2022
This reverts commit 9d92e51.

# Conflicts:
#	.github/workflows/deploy.yml
#	scripts/docker-login.sh
golanha pushed a commit that referenced this pull request Sep 14, 2022
* adding jaeger to api server

* expose docker user

* Revert "expose docker user"

This reverts commit 3873d8c.

* omit login to git registry

* Revert "add extra registries (#1364)"

This reverts commit 9d92e51.

# Conflicts:
#	.github/workflows/deploy.yml
#	scripts/docker-login.sh

* indentation
hkube-ci pushed a commit that referenced this pull request Sep 14, 2022
* adding jaeger to api server

* expose docker user

* Revert "expose docker user"

This reverts commit 3873d8c.

* omit login to git registry

* Revert "add extra registries (#1364)"

This reverts commit 9d92e51.

# Conflicts:
#	.github/workflows/deploy.yml
#	scripts/docker-login.sh

* indentation .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Sep 14, 2022
* adding jaeger to api server

* expose docker user

* Revert "expose docker user"

This reverts commit 3873d8c.

* omit login to git registry

* Revert "add extra registries (#1364)"

This reverts commit 9d92e51.

# Conflicts:
#	.github/workflows/deploy.yml
#	scripts/docker-login.sh

* indentation .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment