Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline status bug #1408

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Pipeline status bug #1408

merged 2 commits into from
Aug 30, 2021

Conversation

nassiharel
Copy link
Contributor

@nassiharel nassiharel commented Aug 30, 2021

This change is Reviewable

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nassiharel)

@nassiharel nassiharel merged commit ba358f3 into master Aug 30, 2021
@nassiharel nassiharel deleted the pipeline_status_bug branch August 30, 2021 14:32
hkube-ci pushed a commit that referenced this pull request Aug 30, 2021
* feat: add state checks tests

* feat: add conditional job update .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Aug 30, 2021
* feat: add state checks tests

* feat: add conditional job update .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants