-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix rebuild issue #1414
feat: fix rebuild issue #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nassiharel)
core/algorithm-builder/lib/state/state-manager.js, line 42 at r1 (raw file):
const buildWatch = await this._etcd.algorithms.builds.watch({ buildId }); if (!buildWatch) { await this._etcd.algorithms.builds.set(build);
You don't need to watch it again? Or is the watch still active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yehiyam)
core/algorithm-builder/lib/state/state-manager.js, line 42 at r1 (raw file):
Previously, yehiyam wrote…
You don't need to watch it again? Or is the watch still active
still active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nassiharel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nassiharel)
Co-authored-by: yehiyam <yehiyam@users.noreply.github.com> .... bump version [skip ci]
Co-authored-by: yehiyam <yehiyam@users.noreply.github.com> .... bump version [skip ci]
This change is