Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix rebuild issue #1414

Merged
merged 3 commits into from
Sep 2, 2021
Merged

feat: fix rebuild issue #1414

merged 3 commits into from
Sep 2, 2021

Conversation

nassiharel
Copy link
Contributor

@nassiharel nassiharel commented Sep 1, 2021

This change is Reviewable

@nassiharel nassiharel requested a review from yehiyam September 1, 2021 13:10
@nassiharel nassiharel linked an issue Sep 1, 2021 that may be closed by this pull request
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nassiharel)


core/algorithm-builder/lib/state/state-manager.js, line 42 at r1 (raw file):

        const buildWatch = await this._etcd.algorithms.builds.watch({ buildId });
        if (!buildWatch) {
            await this._etcd.algorithms.builds.set(build);

You don't need to watch it again? Or is the watch still active

Copy link
Contributor Author

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yehiyam)


core/algorithm-builder/lib/state/state-manager.js, line 42 at r1 (raw file):

Previously, yehiyam wrote…

You don't need to watch it again? Or is the watch still active

still active

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nassiharel)

@yehiyam yehiyam enabled auto-merge (squash) September 2, 2021 12:11
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nassiharel)

@nassiharel nassiharel disabled auto-merge September 2, 2021 12:11
@nassiharel nassiharel merged commit 5b19401 into master Sep 2, 2021
@nassiharel nassiharel deleted the algorithm_rebuild branch September 2, 2021 12:12
hkube-ci pushed a commit that referenced this pull request Sep 2, 2021
Co-authored-by: yehiyam <yehiyam@users.noreply.github.com> .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Sep 2, 2021
Co-authored-by: yehiyam <yehiyam@users.noreply.github.com> .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuild failed Error: unable to find build ->...
2 participants