Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable datasources mount if service is disabled #1456

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

yehiyam
Copy link
Contributor

@yehiyam yehiyam commented Nov 17, 2021

This change is Reviewable

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yehiyam)

@yehiyam yehiyam enabled auto-merge (squash) November 23, 2021 13:26
@yehiyam yehiyam merged commit bd8f426 into master Nov 23, 2021
@yehiyam yehiyam deleted the datasources-enabled branch November 23, 2021 13:29
hkube-ci pushed a commit that referenced this pull request Nov 23, 2021
hkube-ci pushed a commit that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot disable datasource in worker when datasource PVC is not available
2 participants