Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log redirect command #1584

Merged
merged 2 commits into from
May 1, 2022
Merged

fix log redirect command #1584

merged 2 commits into from
May 1, 2022

Conversation

yehiyam
Copy link
Contributor

@yehiyam yehiyam commented Apr 26, 2022

This change is Reviewable

@yehiyam
Copy link
Contributor Author

yehiyam commented Apr 26, 2022

/deploy

@hkube-ci hkube-ci temporarily deployed to dev April 26, 2022 14:32 Inactive
@yehiyam
Copy link
Contributor Author

yehiyam commented Apr 27, 2022

/deploy

@yehiyam
Copy link
Contributor Author

yehiyam commented Apr 27, 2022

/deploy

@hkube-ci hkube-ci temporarily deployed to dev April 27, 2022 08:10 Inactive
Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you need to fix the log log redirect?

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yehiyam)

Copy link
Contributor Author

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1297
changed the way logs are redirected to file to help with stuck algorithm after seg-fault

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yehiyam)

@yehiyam yehiyam requested a review from golanha April 28, 2022 06:29
Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yehiyam)

@yehiyam yehiyam merged commit 116e8a2 into master May 1, 2022
@yehiyam yehiyam deleted the redirect-logs branch May 1, 2022 09:38
hkube-ci pushed a commit that referenced this pull request May 1, 2022
* fix log redirect command

* fix log file path .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request May 1, 2022
* fix log redirect command

* fix log file path .... bump version [skip ci]
@yehiyam yehiyam linked an issue May 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants