Graphql

[maty21]

This change is 

[maty21]

/deploy

[maty21]

/deploy

[maty21]

/deploy

[maty21]

/deploy dev1

[maty21]

/deploy dev1

[maty21]

/deploy dev1

[golanha]

core/api-server/api/graphql/resolvers.js line 291 at r1 (raw file):

module.exports = new GraphqlResolvers();

// const resolvers = {

Remove comment

[golanha]

Reviewed 9 of 68 files at r1, all commit messages.
Reviewable status: 9 of 68 files reviewed, 3 unresolved discussions (waiting on @golanha and @maty21)

---

index.html line 12 at r1 (raw file):

    <meta charset="utf-8">
  <link rel="dns-prefetch" href="https://github.githubassets.com">
  <link rel="dns-prefetch" href="https://avatars.githubusercontent.com">

Remove the file

---

.github/workflows/deploy.yml line 80 at r1 (raw file):

      - uses: actions/setup-node@v2-beta
        with:
          node-version: 14.x

Change to 18

[golanha]

Reviewed 1 of 68 files at r1.
Reviewable status: 9 of 68 files reviewed, 11 unresolved discussions (waiting on @golanha and @maty21)

---

core/api-server/api/graphql/graphql-server.js line 29 at r2 (raw file):

                    return {
                        async drainServer() {
                            // subscriptionServer.close();

Do you plan to do something on drainServer?

---

core/api-server/api/graphql/graphql-server.js line 55 at r2 (raw file):

module.exports = graphqlServer;
   // const subscriptionServer = SubscriptionServer.create({

Left in remark, is it needed?

---

core/api-server/api/graphql/resolvers.js line 3 at r2 (raw file):

/* eslint-disable no-plusplus */
/* eslint-disable default-case */
const { GraphQLScalarType } = require('graphql');

GraphQLScalarType use in comment.

Code quote:

 GraphQLScalarType 

---

core/api-server/api/graphql/resolvers.js line 34 at r2 (raw file):

        //         }
        //     }
        // });

Remove remarked code

Code quote:

        //     name: 'Object',
        //     description: 'Arbitrary object',
        //     parseValue: (value) => {
        //         return typeof value === 'object' ? value
        //             : typeof value === 'string' ? JSON.parse(value)
        //                 : null;
        //     },
        //     serialize: (value) => {
        //         return typeof value === 'object' ? value
        //             : typeof value === 'string' ? JSON.parse(value)
        //                 : null;
        //     },
        //     parseLiteral: (ast) => {
        //         switch (ast.kind) {
        //             case Kind.STRING: return JSON.parse(ast.value);
        //             case Kind.OBJECT: throw new Error('Not sure what to do with OBJECT for ObjectScalarType');
        //             default: return null;
        //         }
        //     }
        // });

---

core/api-server/api/graphql/resolvers.js line 59 at r2 (raw file):

    }
    async queryExperiments() {
        return await dbQueires._getExperiments();

No need for the await since its the return value

Code quote:

await

---

core/api-server/api/graphql/resolvers.js line 126 at r2 (raw file):

    _getQueryResolvers() {
        return {
            jobsAggregated: async (parent, args, context, info) => {

Never used

Code quote:

info

---

core/api-server/api/graphql/resolvers.js line 144 at r2 (raw file):

                return stats;
            },
            jobsByExperimentName: (parent, args, context, info) => {

Never used , many of the methods below contain unused parameters.

Code quote:

context, info

---

core/api-server/api/graphql/resolvers.js line 261 at r2 (raw file):

            numberIncremented: {
                subscribe: () => {
                    return pubsub.asyncIterator(['NUMBER_INCREMENTED']);

pub sub is not defined anywhere

Code quote:

pubsub

[golanha]

Reviewed 58 of 68 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 19 unresolved discussions (waiting on @maty21)

---

core/api-server/api/graphql/queries/get-pipeline-stats.js line 18 at r2 (raw file):

    }
    catch (e) {
        log.error(e.message, { component: 'pipeline-stats' }, e);

log is not defined

Code quote:

log

---

core/api-server/api/graphql/queries/get-pipeline-stats.js line 33 at r2 (raw file):

};

const getPipelinesStats = async ({ limit, db }) => {

Limit is not used

Code quote:

limit

---

core/api-server/api/graphql/queries/prefered-querier.js line 2 at r2 (raw file):

const { default: axios } = require('axios');
const querystring = require('query-string');

querystring is not used

Code quote:

querystring

---

core/api-server/api/graphql/queries/statistics-querier.js line 45 at r2 (raw file):

        this.run();
    }
    async getStatisticsResults() {

lint spaces problem here.

---

core/api-server/api/graphql/schemas/datasource-schema.js line 3 at r2 (raw file):

const { gql } = require('apollo-server');

Extra blank line

---

core/api-server/api/graphql/schemas/discovery-schema.js line 5 at r2 (raw file):

const discoveryTypeDefs = gql`

type Pipelinedriver {

Should have capital PipelineDriver

Code quote:

Pipelinedriver

---

core/api-server/api/graphql/schemas/experiment-schema.js line 2 at r2 (raw file):

const { gql } = require('apollo-server');

lint new lines problems

---

core/api-server/dev/alg1.py line 11 at r2 (raw file):

if __name__ == "__main__":
    Algorunner.Run(start=start) 

why did you add a python algorithm here?

Code quote:

from __future__ import print_function, division, absolute_import
from hkube_python_wrapper import Algorunner
import time
def start(args, hkubeapi):
    for i in range(5):
        print('waiting',i)
        time.sleep(1)
    return 'foo'

if __name__ == "__main__":
    Algorunner.Run(start=start)

[maty21]

/deploy test

[golanha]

Reviewed 1 of 68 files at r1, 22 of 22 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: all files reviewed, 14 unresolved discussions (waiting on @maty21)