-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test get pod #1647
test get pod #1647
Conversation
/deploy dev1 |
/deploy dev1 |
/deploy dev1 |
/deploy dev1 |
/deploy dev1 |
/deploy |
This reverts commit bec175c.
/deploy |
/deploy dev1 |
/deploy dev1 |
/deploy dev1 |
/deploy dev1 |
/deploy dev1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 6 files at r1, all commit messages.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @zivglik)
core/api-server/api/task-logs/consts.js
line 38 at r1 (raw file):
};
Move to consts module
core/api-server/api/task-logs/logs.js
line 84 at r1 (raw file):
level: 'info', timestamp: Date.now() }];
remove
Code quote:
logsData.logs = [{
message: [`image ${currentAlgorunner.image} not exist`],
level: 'info',
timestamp: Date.now()
}];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 8 files reviewed, 3 unresolved discussions (waiting on @golanha)
core/api-server/api/task-logs/consts.js
line 38 at r1 (raw file):
Previously, golanha (Golan Hallel) wrote…
Move to consts module
Done.
Code quote:
NOT_EXIST: 'NOT_EXIST',
core/api-server/api/task-logs/consts.js
line 39 at r1 (raw file):
consts module
core/api-server/api/task-logs/logs.js
line 84 at r1 (raw file):
Previously, golanha (Golan Hallel) wrote…
remove
Done.
/deploy dev1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
* test get pod * fix lines get pod * add podStatus * fix ref kubernetes client * fix algorunner * Write no image error to log * Revert "Write no image error to log" This reverts commit bec175c. * fix after run job error msg and input value * fix path nodes from graph * fin undefined map node input * fix run test * get pod Status from o project hkube/consts * update hkube/consts Co-Authored-By: Golan Hallel <golanha@rnd-hub.com> .... bump version [skip ci]
* test get pod * fix lines get pod * add podStatus * fix ref kubernetes client * fix algorunner * Write no image error to log * Revert "Write no image error to log" This reverts commit bec175c. * fix after run job error msg and input value * fix path nodes from graph * fin undefined map node input * fix run test * get pod Status from o project hkube/consts * update hkube/consts Co-Authored-By: Golan Hallel <golanha@rnd-hub.com> .... bump version [skip ci]
This change is