Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test get pod #1647

Merged
merged 13 commits into from
Jan 11, 2023
Merged

test get pod #1647

merged 13 commits into from
Jan 11, 2023

Conversation

zivglik
Copy link
Contributor

@zivglik zivglik commented Jan 1, 2023

This change is Reviewable

@zivglik
Copy link
Contributor Author

zivglik commented Jan 1, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 1, 2023 11:00 Inactive
@zivglik
Copy link
Contributor Author

zivglik commented Jan 1, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 1, 2023 11:12 Inactive
@zivglik
Copy link
Contributor Author

zivglik commented Jan 2, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 2, 2023 09:51 Inactive
@zivglik
Copy link
Contributor Author

zivglik commented Jan 2, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 2, 2023 11:17 Inactive
@zivglik
Copy link
Contributor Author

zivglik commented Jan 2, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 2, 2023 11:56 Inactive
@golanha
Copy link
Member

golanha commented Jan 8, 2023

/deploy

@hkube-ci hkube-ci temporarily deployed to dev January 8, 2023 07:11 Inactive
@golanha
Copy link
Member

golanha commented Jan 8, 2023

/deploy

@hkube-ci hkube-ci temporarily deployed to dev January 8, 2023 12:41 Inactive
@zivglik
Copy link
Contributor Author

zivglik commented Jan 9, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 9, 2023 09:18 Inactive
@zivglik
Copy link
Contributor Author

zivglik commented Jan 9, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 9, 2023 12:04 Inactive
@zivglik
Copy link
Contributor Author

zivglik commented Jan 9, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 9, 2023 12:37 Inactive
@zivglik
Copy link
Contributor Author

zivglik commented Jan 9, 2023

/deploy dev1

@zivglik zivglik requested a review from golanha January 9, 2023 15:43
@zivglik
Copy link
Contributor Author

zivglik commented Jan 9, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 9, 2023 15:49 Inactive
Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 6 files at r1, all commit messages.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @zivglik)


core/api-server/api/task-logs/consts.js line 38 at r1 (raw file):

};

Move to consts module


core/api-server/api/task-logs/logs.js line 84 at r1 (raw file):

                        level: 'info',
                        timestamp: Date.now()
                    }];

remove

Code quote:

                    logsData.logs = [{
                        message: [`image ${currentAlgorunner.image} not exist`],
                        level: 'info',
                        timestamp: Date.now()
                    }];

Copy link
Contributor Author

@zivglik zivglik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 8 files reviewed, 3 unresolved discussions (waiting on @golanha)


core/api-server/api/task-logs/consts.js line 38 at r1 (raw file):

Previously, golanha (Golan Hallel) wrote…

Move to consts module

Done.

Code quote:

NOT_EXIST: 'NOT_EXIST',

core/api-server/api/task-logs/consts.js line 39 at r1 (raw file):

consts module


core/api-server/api/task-logs/logs.js line 84 at r1 (raw file):

Previously, golanha (Golan Hallel) wrote…

remove

Done.

@zivglik
Copy link
Contributor Author

zivglik commented Jan 11, 2023

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev January 11, 2023 06:02 Inactive
Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@golanha golanha merged commit 1d277c6 into master Jan 11, 2023
@golanha golanha deleted the check-pod-exist branch January 11, 2023 07:03
hkube-ci pushed a commit that referenced this pull request Jan 11, 2023
* test get pod

* fix lines get pod

* add podStatus

* fix ref kubernetes client

* fix algorunner

* Write no image error to log

* Revert "Write no image error to log"

This reverts commit bec175c.

* fix after run job error msg and input value

* fix path nodes from graph

* fin undefined map node input

* fix run test

* get pod Status  from o project hkube/consts

* update hkube/consts

Co-Authored-By: Golan Hallel <golanha@rnd-hub.com> .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Jan 11, 2023
* test get pod

* fix lines get pod

* add podStatus

* fix ref kubernetes client

* fix algorunner

* Write no image error to log

* Revert "Write no image error to log"

This reverts commit bec175c.

* fix after run job error msg and input value

* fix path nodes from graph

* fin undefined map node input

* fix run test

* get pod Status  from o project hkube/consts

* update hkube/consts

Co-Authored-By: Golan Hallel <golanha@rnd-hub.com> .... bump version [skip ci]
golanha pushed a commit that referenced this pull request Jan 22, 2023
schema fix
golanha pushed a commit that referenced this pull request Jan 22, 2023
hkube-ci pushed a commit that referenced this pull request Jan 22, 2023
schema fix .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Jan 22, 2023
schema fix .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants