-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing order of calls to services #1828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golanha
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @zivglik)
hkube-ci
pushed a commit
that referenced
this pull request
Nov 15, 2023
hkube-ci
pushed a commit
that referenced
this pull request
Nov 15, 2023
RonShvarz
pushed a commit
that referenced
this pull request
Nov 29, 2023
hkube-ci
pushed a commit
that referenced
this pull request
Nov 29, 2023
hkube-ci
pushed a commit
that referenced
this pull request
Nov 29, 2023
RonShvarz
added a commit
that referenced
this pull request
Nov 29, 2023
* Changing order of calls to services (#1828) * Changing order of calls to services (#1828) .... bump version [skip ci] * Changing order of calls to services (#1828) .... bump version [skip ci] * scaledown race condition (#1830) * prevent initial scaledown due to scaler interval before auto_scaler updates required value * revert to verify behaviour change * fix race condition in interval, fix hkube.consts version that has throughput * add reason to stop,and filter by pause (#1836) * add reason to stop,and filter by pause * fix add enum pipeline statuses * statelessCount scaling optimization (#1833) * prevent initial scareup being lower then minStatelessCount * Enhanced message for bothLimit * missing semicolon * Added correct parse for SCALE_INTERVENTION_LOG_THROTTLE_TIME * scaledown condition to handle non - limited pods scaledown. --------- Co-authored-by: zivglik <38244490+zivglik@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
hkube-ci
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Changing order of calls to services (#1828) * Changing order of calls to services (#1828) .... bump version [skip ci] * Changing order of calls to services (#1828) .... bump version [skip ci] * scaledown race condition (#1830) * prevent initial scaledown due to scaler interval before auto_scaler updates required value * revert to verify behaviour change * fix race condition in interval, fix hkube.consts version that has throughput * add reason to stop,and filter by pause (#1836) * add reason to stop,and filter by pause * fix add enum pipeline statuses * statelessCount scaling optimization (#1833) * prevent initial scareup being lower then minStatelessCount * Enhanced message for bothLimit * missing semicolon * Added correct parse for SCALE_INTERVENTION_LOG_THROTTLE_TIME * scaledown condition to handle non - limited pods scaledown. --------- Co-authored-by: zivglik <38244490+zivglik@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> .... bump version [skip ci]
hkube-ci
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Changing order of calls to services (#1828) * Changing order of calls to services (#1828) .... bump version [skip ci] * Changing order of calls to services (#1828) .... bump version [skip ci] * scaledown race condition (#1830) * prevent initial scaledown due to scaler interval before auto_scaler updates required value * revert to verify behaviour change * fix race condition in interval, fix hkube.consts version that has throughput * add reason to stop,and filter by pause (#1836) * add reason to stop,and filter by pause * fix add enum pipeline statuses * statelessCount scaling optimization (#1833) * prevent initial scareup being lower then minStatelessCount * Enhanced message for bothLimit * missing semicolon * Added correct parse for SCALE_INTERVENTION_LOG_THROTTLE_TIME * scaledown condition to handle non - limited pods scaledown. --------- Co-authored-by: zivglik <38244490+zivglik@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> .... bump version [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is