Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing order of calls to services #1828

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Changing order of calls to services #1828

merged 1 commit into from
Nov 15, 2023

Conversation

zivglik
Copy link
Contributor

@zivglik zivglik commented Nov 15, 2023

This change is Reviewable

Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zivglik)

@golanha golanha merged commit 7fcabb2 into master Nov 15, 2023
5 checks passed
@golanha golanha deleted the fix-fall-api-from-ui branch November 15, 2023 14:49
RonShvarz pushed a commit that referenced this pull request Nov 29, 2023
RonShvarz added a commit that referenced this pull request Nov 29, 2023
* Changing order of calls to services (#1828)

* Changing order of calls to services (#1828) .... bump version [skip ci]

* Changing order of calls to services (#1828) .... bump version [skip ci]

* scaledown race condition (#1830)

* prevent initial scaledown due to scaler interval before auto_scaler updates required value

* revert to verify behaviour change

* fix race condition in interval, fix hkube.consts version that has throughput

* add reason to stop,and filter by pause (#1836)

* add reason to stop,and filter by pause

* fix add enum pipeline statuses

* statelessCount scaling optimization (#1833)

* prevent initial scareup being lower then minStatelessCount

* Enhanced message for bothLimit

* missing semicolon

* Added correct parse for SCALE_INTERVENTION_LOG_THROTTLE_TIME

* scaledown condition to handle non - limited pods scaledown.

---------

Co-authored-by: zivglik <38244490+zivglik@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
hkube-ci pushed a commit that referenced this pull request Nov 29, 2023
* Changing order of calls to services (#1828)

* Changing order of calls to services (#1828) .... bump version [skip ci]

* Changing order of calls to services (#1828) .... bump version [skip ci]

* scaledown race condition (#1830)

* prevent initial scaledown due to scaler interval before auto_scaler updates required value

* revert to verify behaviour change

* fix race condition in interval, fix hkube.consts version that has throughput

* add reason to stop,and filter by pause (#1836)

* add reason to stop,and filter by pause

* fix add enum pipeline statuses

* statelessCount scaling optimization (#1833)

* prevent initial scareup being lower then minStatelessCount

* Enhanced message for bothLimit

* missing semicolon

* Added correct parse for SCALE_INTERVENTION_LOG_THROTTLE_TIME

* scaledown condition to handle non - limited pods scaledown.

---------

Co-authored-by: zivglik <38244490+zivglik@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com> .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Nov 29, 2023
* Changing order of calls to services (#1828)

* Changing order of calls to services (#1828) .... bump version [skip ci]

* Changing order of calls to services (#1828) .... bump version [skip ci]

* scaledown race condition (#1830)

* prevent initial scaledown due to scaler interval before auto_scaler updates required value

* revert to verify behaviour change

* fix race condition in interval, fix hkube.consts version that has throughput

* add reason to stop,and filter by pause (#1836)

* add reason to stop,and filter by pause

* fix add enum pipeline statuses

* statelessCount scaling optimization (#1833)

* prevent initial scareup being lower then minStatelessCount

* Enhanced message for bothLimit

* missing semicolon

* Added correct parse for SCALE_INTERVENTION_LOG_THROTTLE_TIME

* scaledown condition to handle non - limited pods scaledown.

---------

Co-authored-by: zivglik <38244490+zivglik@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com> .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants