Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seperate api validator to files #884

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Conversation

nassiharel
Copy link
Contributor

@nassiharel nassiharel commented Jul 20, 2020

This change is Reviewable

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 28 of 28 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nassiharel)


core/api-server/lib/service/algorithms.js, line 140 at r1 (raw file):

    async getAlgorithm(options) {
        validator.jobs.validateName(options);

jobs?


core/api-server/lib/service/readme.js, line 60 at r1 (raw file):

    async getAlgorithm(options) {
        const { name } = options;
        validator.jobs.validateName(options);

job?

@yehiyam yehiyam merged commit 186fe1e into master Jul 20, 2020
@yehiyam yehiyam deleted the api_server_validation branch July 20, 2020 11:56
hkube-ci pushed a commit that referenced this pull request Jul 20, 2020
* feat: seperate api validator to files

* feat: seperate api validator to files .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Jul 20, 2020
* feat: seperate api validator to files

* feat: seperate api validator to files .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants