add warning for algorithm-queue not created

core/algorithm-operator/lib/helpers/etcd.js

@@ -29,8 +29,12 @@ class Etcd extends EventEmitter {
         return this._etcd.algorithms.store.get({ name });
     }
 
-    getAlgorithmTemplates() {
-        return this._etcd.algorithms.store.list();
+    async getAlgorithmTemplates() {
+        const [algorithms, count] = await Promise.all([
+            this._etcd.algorithms.store.list(),
+            this._etcd.algorithms.store.count()
+        ]);
+        return { algorithms, count };
     }
 
     removeAlgorithmData(name) {

core/algorithm-operator/lib/operator.js

@@ -44,12 +44,12 @@ class Operator {
         try {
             log.debug('Reconcile interval.', { component });
             const configMap = await kubernetes.getVersionsConfigMap();
-            const algorithms = await etcd.getAlgorithmTemplates();
+            const { algorithms, count } = await etcd.getAlgorithmTemplates();
             await Promise.all([
                 this._algorithmBuilds({ ...configMap }, options),
                 this._tenosrboards({ ...configMap, boardTimeOut: this._boardTimeOut }, options),
                 this._algorithmDebug(configMap, algorithms, options),
-                this._algorithmQueue({ ...configMap, resources: options.resources.algorithmQueue }, algorithms, options),
+                this._algorithmQueue({ ...configMap, resources: options.resources.algorithmQueue }, algorithms, options, count),
             ]);
         }
         catch (e) {
@@ -121,7 +121,8 @@ class Operator {
         });
     }
 
-    async _algorithmQueue({ versions, registry, clusterOptions, resources }, algorithms, options) {
+    async _algorithmQueue({ versions, registry, clusterOptions, resources }, algorithms, options, count) {
+        this._logAlgorithmCountError(algorithms, count);
         const deployments = await kubernetes.getDeployments({ labelSelector: `type=${CONTAINERS.ALGORITHM_QUEUE}` });
         await algorithmQueueReconciler.reconcile({
             deployments,
@@ -133,6 +134,12 @@ class Operator {
             options
         });
     }
+
+    _logAlgorithmCountError(algorithms, count) {
+        if (algorithms.length < count) {
+            log.throttle.error(`Only ${algorithms.length} algorithm-queue's can be created, but ${count} algorithms are defined. Please delete unused algorithms`, { component });
+        }
+    }
 }
 
 module.exports = new Operator();

core/algorithm-operator/package.json

@@ -16,7 +16,7 @@
   "dependencies": {
     "@hkube/config": "^2.0.7",
     "@hkube/consts": "^1.0.21",
-    "@hkube/etcd": "^5.0.37",
+    "@hkube/etcd": "^5.0.38",
     "@hkube/healthchecks": "^1.0.0",
     "@hkube/kubernetes-client": "^1.0.32",
     "@hkube/logger": "^1.0.25",

core/algorithm-operator/tests/test.js

@@ -21,6 +21,9 @@ describe('bootstrap', () => {
         mockery.disable();
         decache('../bootstrap');
     });
+    beforeEach(async () => {
+        await etcd._etcd._client.delete('/algorithms/store', { isPrefix: true })
+    });
     it('should init without error', async () => {
 
     });
@@ -29,4 +32,20 @@ describe('bootstrap', () => {
         const template = await etcd.getAlgorithmTemplate({ name: 'algo2' });
         expect(template).to.eql(templateStoreStub[1]);
     });
+
+    it('should list template store', async () => {
+        await Promise.all(templateStoreStub.map(a => etcd._etcd.algorithms.store.set(a)));
+        const { algorithms, count } = await etcd.getAlgorithmTemplates();
+        expect(algorithms).to.deep.include(templateStoreStub[1]);
+        expect(algorithms.length).to.eql(count);
+    });
+    it('should list template store above limit', async () => {
+
+        await Promise.all([...Array(110).keys()].map(i => etcd._etcd.algorithms.store.set({
+            name: `key-${i}`,
+        })));
+        const { algorithms, count } = await etcd.getAlgorithmTemplates();
+        expect(algorithms).to.deep.include({ name: 'key-99' });
+        expect(algorithms.length).to.not.eql(count);
+    });
 });