Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong validation of algorithmEnv #994

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Conversation

yehiyam
Copy link
Contributor

@yehiyam yehiyam commented Oct 25, 2020

This change is Reviewable

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@yehiyam
Copy link
Contributor Author

yehiyam commented Oct 25, 2020

/deploy

@hkube-ci hkube-ci temporarily deployed to dev October 25, 2020 12:29 Inactive
@yehiyam yehiyam merged commit 4b438d8 into master Oct 25, 2020
yehiyam added a commit that referenced this pull request Oct 27, 2020
@nassiharel nassiharel deleted the algorithmEnv-validation branch October 28, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API server fail validate algorithmEnv from: " fieldRef - configMapKeyRef - resourceFieldRef - secretKeyRef"
3 participants