#10 HPA feat - initial version for OBI metrics adapter #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xff-dev
reviewed
Nov 4, 2022
Abirdcfly
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
/lgtm
Later we will need to add tests to the subsequent pr and add instructions for use to https://github.com/kube-arbiter/website
|
For testcase and doc, tracking here: #10 |
nkwangleiGIT
added a commit
to nkwangleiGIT/arbiter
that referenced
this pull request
Jul 25, 2023
kube-arbiter#10 HPA feat - initial version for OBI metrics adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add new feature to support OBI based HPA using external metrics adapter
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?