Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1872080: Dockerfile: Remove conditional for symlinking python3 to python #90

Conversation

timflannagan
Copy link

This conditional was needed as there was still a gap between our CI images, which are RHEL8-based, and the ART images, which was still on RHEL7.

Now that it appears the switch has been made, we can remove the conditional and always use the alternatives command to symlink the python3 rpm to the python command.

This conditional was needed as there was still a gap between our CI images, which are RHEL8-based, and the ART images, which was still on RHEL7.

Now that it appears the switch has been made, we can remove the conditional and always use the `alternatives` command to symlink the python3 rpm to the python command.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@yselkowitz
Copy link

/retitle Bug 1872080: Dockerfile: Remove conditional for symlinking python3 to python
/lgtm

@openshift-ci-robot
Copy link

@yselkowitz: changing LGTM is restricted to collaborators

In response to this:

/retitle Bug 1872080: Dockerfile: Remove conditional for symlinking python3 to python
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@yselkowitz: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Bug 1872080: Dockerfile: Remove conditional for symlinking python3 to python
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Author

/retitle Bug 1872080: Dockerfile: Remove conditional for symlinking python3 to python

@openshift-ci-robot openshift-ci-robot changed the title Dockerfile: Remove conditional for symlinking python3 to python Bug 1872080: Dockerfile: Remove conditional for symlinking python3 to python Sep 11, 2020
@openshift-ci-robot
Copy link

@timflannagan1: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Dockerfile: Remove conditional for symlinking python3 to python

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 11, 2020
@timflannagan timflannagan added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 619f39a into kube-reporting:master Sep 11, 2020
@openshift-ci-robot
Copy link

@timflannagan1: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

In response to this:

Bug 1872080: Dockerfile: Remove conditional for symlinking python3 to python

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants