Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signal handling for runtime objects #152

Closed
clux opened this issue Feb 27, 2020 · 0 comments · Fixed by #218
Closed

Add signal handling for runtime objects #152

clux opened this issue Feb 27, 2020 · 0 comments · Fixed by #218
Assignees
@clux
Labels
runtime controller runtime related

Comments

@clux
Copy link
Member

clux commented Feb 27, 2020

Reflectors and Informers should stop their ongoing watches if SIGTERM has been received. This allows any event handlers to do the final iterations before k8s kills a controller.

Might have to be integrated with #151
@clux clux added enhancement help wanted Not immediately prioritised, please help! runtime controller runtime related and removed enhancement labels Feb 27, 2020
clux added a commit that referenced this issue Apr 6, 2020
@clux
convert Reflector to use Informer internally + self-drive
7f82abb 
fixes #151 and fixes #152 with tokio::signal and a futures::select call.
drops a lot of Reflector logic to defer to Informer.

Seems to work pretty well, but may need to deal with desyncs better.
Ran into the unordered resourceVersion issue on a really old namespace.
Need to double check if that can happen with old version.
@clux clux mentioned this issue Apr 6, 2020
Merged
@clux clux self-assigned this Apr 6, 2020
@clux clux linked a pull request Apr 6, 2020 that will close this issue
self-driving reflector + signal handling #218
Merged
@clux clux removed the help wanted Not immediately prioritised, please help! label Apr 7, 2020
clux added a commit that referenced this issue Apr 7, 2020
@clux
convert Reflector to use Informer internally + self-drive
ffa9dca 
fixes #151 and fixes #152 with tokio::signal and a futures::select call.
drops a lot of Reflector logic to defer to Informer.

Seems to work pretty well, but may need to deal with desyncs better.
Ran into the unordered resourceVersion issue on a really old namespace.
Need to double check if that can happen with old version.
clux added a commit that referenced this issue Apr 8, 2020
@clux
clean up signal handling + handle SIGTERM - for #152
a7f4813
@clux clux closed this as completed in #218 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clux clux

Labels
runtime controller runtime related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

self-driving reflector + signal handling kube-rs/kube
1 participant
@clux