Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "disable-compression" to selectively disable Client Compression #1627

Closed
markdingram opened this issue Nov 5, 2024 · 1 comment · Fixed by #1628
Closed

Add "disable-compression" to selectively disable Client Compression #1627

markdingram opened this issue Nov 5, 2024 · 1 comment · Fixed by #1628
Assignees
@markdingram
Labels
client kube Client related

Comments

@markdingram
Copy link
Contributor

Would you like to work on this feature?

yes

What problem are you trying to solve?

Currently compression is tied to the gzip feature. The use case for bringing in the disable-compression config option is to facilitate a gradual rollout across many clusters without needing 2 binaries.

Previously discussed here:
#1331 (comment)

Describe the solution you'd like

Add the "disable-compression" flag & flow through to the Client construction to allow selective disable even when gzip feature is enabled

Describe alternatives you've considered

None

Documentation, Adoption, Migration Strategy

No response

Target crate for feature

kube-client
@clux
Copy link
Member

clux commented Nov 5, 2024 •
edited
Loading

Seems reasonable to me. Can be defaulted sensibly, and can be documented as 'only has an effect when gzip feature is enabled'.

Thanks for the issue before a PR and good context links btw!

@clux clux added the client kube Client related label Nov 5, 2024
markdingram added a commit to markdingram/kube-rs that referenced this issue Nov 5, 2024
@markdingram
Feature: Add config setting to disable gzip compression kube-rs#1627
3be2b14 
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options

Signed-off-by: Mark Ingram <mark@lincs.dev>
@clux clux linked a pull request Nov 5, 2024 that will close this issue
Feature: Add config setting to disable gzip compression #1627 #1628
Merged
markdingram added a commit to markdingram/kube-rs that referenced this issue Nov 6, 2024
@markdingram
Feature: Add config setting to disable gzip compression kube-rs#1627
06b4b0e 
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options

Signed-off-by: Mark Ingram <mark@lincs.dev>
markdingram added a commit to markdingram/kube-rs that referenced this issue Nov 6, 2024
@markdingram
Feature: Add config setting to disable gzip compression kube-rs#1627
fbdcad9 
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options

Signed-off-by: Mark Ingram <mark@lincs.dev>
markdingram added a commit to markdingram/kube-rs that referenced this issue Nov 6, 2024
@markdingram
Feature: Add config setting to disable gzip compression kube-rs#1627
62c7009 
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options

Signed-off-by: Mark Ingram <mark@lincs.dev>
markdingram added a commit to markdingram/kube-rs that referenced this issue Nov 6, 2024
@markdingram
Feature: Add config setting to disable gzip compression kube-rs#1627
71598b8 
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options

Signed-off-by: Mark Ingram <mark@lincs.dev>
markdingram added a commit to markdingram/kube-rs that referenced this issue Nov 6, 2024
@markdingram
Feature: Add config setting to disable gzip compression kube-rs#1627
22dfd0a 
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options

Signed-off-by: Mark Ingram <mark@lincs.dev>
clux added a commit that referenced this issue Nov 19, 2024
@markdingram @clux
Feature: Add config setting to disable gzip compression #1627 (#1628)
e0aa73d 
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options

Signed-off-by: Mark Ingram <mark@lincs.dev>
Co-authored-by: Eirik A <sszynrae@gmail.com>
@clux clux mentioned this issue Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markdingram markdingram

Labels
client kube Client related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Add config setting to disable gzip compression #1627 markdingram/kube-rs
2 participants
@clux @markdingram