Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde_yaml 0.9 #980

Closed
nightkr opened this issue Aug 9, 2022 · 1 comment · Fixed by #1188
Closed

serde_yaml 0.9 #980

nightkr opened this issue Aug 9, 2022 · 1 comment · Fixed by #1188
Assignees

Comments

@nightkr
Copy link
Member

nightkr commented Aug 9, 2022

serde_yaml 0.9.x now generates documents that are inconsistent with what kubectl (and the rest of the K8s ecosystem) expects (as well as the schemas generated by schemars), see stackabletech/operator-rs#450, dtolnay/serde-yaml#298.

We probably need to figure out a decent strategy for handling this on our end, and discourage use of 0.9 until we have a proper answer.

@clux
Copy link
Member

clux commented Apr 5, 2023

Looking at the issues for this and seeing how both stackable and the example controllers have upgraded to serde_yaml 0.9 I don't think there's a particular need for us to hold back here anymore.

Our usage of serde_yaml is generally only for tests (it's a dev dep in kube-core + kube-derive) with only one legit use case (config loading) from kube-client.

@clux clux self-assigned this Apr 5, 2023
clux added a commit that referenced this issue Apr 5, 2023
Closes #980

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux closed this as completed in #1188 Apr 8, 2023
clux added a commit that referenced this issue Apr 8, 2023
* Bump `serde_yaml` to 0.9

Closes #980

Signed-off-by: clux <sszynrae@gmail.com>

* minor serialization changes + fn removal in serde_yaml

Signed-off-by: clux <sszynrae@gmail.com>

---------

Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants