Revert "kube-derive: Disable option_nullable for CRD generation"
#1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
approved these changes
Apr 13, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
==========================================
- Coverage 73.52% 73.49% -0.04%
==========================================
Files 68 68
Lines 5360 5350 -10
==========================================
- Hits 3941 3932 -9
+ Misses 1419 1418 -1
|
)" This reverts commit 2968e3e. Signed-off-by: David Herberth <github@dav1d.de>
Dav1dde
force-pushed
the
revert-1079-option_nullable
branch
from
5a27bf3
to
25789d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1079
The problem is, that after this change serde behaviour of serializing
Option::Noneasnullis not compatible with the generated CRD anymore and requires fields to be annotated withskip_serializing_if = "Option::is_none".While this is not necessarily incorrect it is also a giant footgun for default behaviour.