Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV from 1.63 to 1.64 #1233

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Bump MSRV from 1.63 to 1.64 #1233

merged 2 commits into from
Jun 30, 2023

Conversation

clux
Copy link
Member

@clux clux commented Jun 30, 2023

Due to msrv from serde_yaml. Has started failing in neighbouring PRs. Still far behind latest.

Also fixes CI issues around cargo deny where we are getting duplicate dependencies. Nothing really we can do about these yet.

clux added 2 commits June 30, 2023 18:07
due to clashes with serde_yaml at 0.9.22

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #1233 (55189ed) into main (5806a2d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   73.04%   73.03%   -0.02%     
==========================================
  Files          69       69              
  Lines        5525     5525              
==========================================
- Hits         4036     4035       -1     
- Misses       1489     1490       +1     

see 1 file with indirect coverage changes

@clux clux marked this pull request as ready for review June 30, 2023 18:06
@clux clux added the changelog-change changelog change category for prs label Jun 30, 2023
@clux clux added this to the 0.84.0 milestone Jun 30, 2023
@clux
Copy link
Member Author

clux commented Jun 30, 2023

Merging this to unblock CI elsewhere.

@clux clux merged commit 56b51f7 into main Jun 30, 2023
18 checks passed
@clux clux deleted the msrv-bump branch June 30, 2023 21:18
@nightkr
Copy link
Member

nightkr commented Jun 30, 2023

Didn't see this on time, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants