-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): Add series implementation for event recorder #1655
feat(runtime): Add series implementation for event recorder #1655
Conversation
adeabe4
to
e09e462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, thanks for this! looks largely sensible to me, gave a quick go over with some quick questions and minor nits, lmk if my thinking makes sense.
79074f2
to
e8e4b54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
=======================================
+ Coverage 75.6% 75.8% +0.3%
=======================================
Files 82 82
Lines 7430 7513 +83
=======================================
+ Hits 5611 5693 +82
- Misses 1819 1820 +1
|
96240f4
to
dd650b2
Compare
Now all tests were passed but I forgot about DCO again... You can review it when you have time and if more improvements are needed I will work on them. If not I have to squash all those commits and we can merge. |
for kube-rs/kube#1655 Signed-off-by: clux <sszynrae@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanups and sorry for the delay, have had a busy week. a few more small comments.
269eed5
to
12ab345
Compare
Signed-off-by: Alexander Gil <pando855@gmail.com>
12ab345
to
cb50617
Compare
I fixed the issues with the tests and squashed all commits. |
…1655) Signed-off-by: Alexander Gil <pando855@gmail.com>
* test out new event recorder interface for kube-rs/kube#1655 Signed-off-by: clux <sszynrae@gmail.com> * cache recorder in Context to use the cache correctly Signed-off-by: clux <sszynrae@gmail.com> * event by ref Signed-off-by: clux <sszynrae@gmail.com> * use official now that it's released Signed-off-by: clux <sszynrae@gmail.com> * merge conflicts Signed-off-by: clux <sszynrae@gmail.com> * fix test compile Signed-off-by: clux <sszynrae@gmail.com> * gen Signed-off-by: clux <sszynrae@gmail.com> --------- Signed-off-by: clux <sszynrae@gmail.com>
Motivation
The current implementation of the event recorder just creates new events which is not enough for my event handling expectations.
Solution
I added a recorder implementation more similar to the one in client-go library. This implementation caches events in local and groups isomorphic events to increment series count on similar events.