Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow constructing a Config from a provided Kubeconfig #236

Merged
merged 1 commit into from
May 7, 2020
Merged

allow constructing a Config from a provided Kubeconfig #236

merged 1 commit into from
May 7, 2020

Conversation

jbg
Copy link
Contributor

@jbg jbg commented May 7, 2020

No description provided.

@clux
Copy link
Member

clux commented May 7, 2020

Yeah, this seems like a sensible way to let users bypass the normal system. Thanks!

@clux clux merged commit 109c3bb into kube-rs:master May 7, 2020
@clux clux mentioned this pull request May 7, 2020
Closed
@clux
Copy link
Member

clux commented May 8, 2020 •
edited
Loading

Ending up making a few changes to this because it makes the custom behaviour the default (which is not actually that intuitive). For next version, I am probably going to have 3 ways to construct (outside of the main Config::infer):

  • Config::from_cluster_env <- renamed from Config::new_from_cluster_env
  • Config::from_kubeconfig <- renamed from Config::new_from_kubeconfig
  • Config::from_custom_kubeconfig - the one added herein

@clux
Copy link
Member

clux commented May 8, 2020

Change: 1a21039

@clux
Copy link
Member

clux commented May 8, 2020

Released in 0.34.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbg @clux @nightkr