Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for runtime API discovery #301

Merged
merged 2 commits into from
Aug 9, 2020
Merged

Conversation

MikailBag
Copy link
Contributor

No description provided.

@clux
Copy link
Member

clux commented Aug 5, 2020

Ooh. Thanks for this. Looks like a very clean addition to the client, totally happy with merging this as it stands.

I wonder whether we could/should hook this into Resource somehow though. Maybe the APIResource results from list_core_api_resources could be converted Into a Resource via Resource::dynamic, then people could use whatever APIs are available directly from that result.

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

kube/src/client/mod.rs Show resolved Hide resolved
@clux
Copy link
Member

clux commented Aug 9, 2020

Going to merge this in. Had a go to identify how it fits in with Resource properly today. It's a little awkward. Trying to tweak it a little. Will ping you in on a subsequent PR @MikailBag .

@clux clux merged commit 130bc75 into kube-rs:master Aug 9, 2020
clux added a commit that referenced this pull request Aug 9, 2020
adds a full example that deals with edge cases of converting all of
these to Resource objects.
clux added a commit that referenced this pull request Aug 10, 2020
tweaks for dynamic resource getters for #301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants