Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pedantic enforcements in kube-derive #321

Merged
merged 4 commits into from
Sep 17, 2020
Merged

remove pedantic enforcements in kube-derive #321

merged 4 commits into from
Sep 17, 2020

Conversation

clux
Copy link
Member

@clux clux commented Sep 11, 2020 •
edited
Loading

does not work with stuff like DNSEndpoint anyway, and we did already clean this up in dynamic.rs.

also:

  • refactors kube-derive a bit for reabability
  • fixed a bug that caused it not to pick up on the shortname attr
  • makes the full GVK required to specify (even if using FooSpec struct, inferring was very magical and strange)

clux added 2 commits September 11, 2020 13:04
@clux
remove pedantic enforcements in kube-derive - fixes #313
7187db7 
also refactors kube-derive a bit for reabability.
also fixed a bug that caused it not to pick up on the shortname attr
@clux
changelog
45a7cbe
@clux clux linked an issue Sep 11, 2020 that may be closed by this pull request
Recommendations for interacting with 3rd party (non k8s) CRDs? #313
Closed
@clux clux merged commit fb6c2ab into master Sep 17, 2020
@clux clux deleted the derive-pedantic branch September 17, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommendations for interacting with 3rd party (non k8s) CRDs?
1 participant
@clux