Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s-openapi #531

Merged
merged 10 commits into from
Jun 16, 2021
Merged

Update k8s-openapi #531

merged 10 commits into from
Jun 16, 2021

Conversation

olix0r
Copy link
Contributor

@olix0r olix0r commented May 21, 2021 •
edited
Loading

This change updates k8s-openapi to pick up Arnavion/k8s-openapi@0a9d7e4,
which implements a workarond for a bug in the Kubernetes Node API
wherein empty lists are encoded as null. This workaround is necessary
until the Kubernetes v1.22 API is released including a change to the
OpenAPI spec in kubernetes/kubernetes#102159.

k8s-openapi has not yet released this fix to crates.io, so instead this
change uses a dependency patch to pull in the latest version from git.

@olix0r
Update k8s-openapi
bf609e5 
This change updates k8s-openapi to pick up Arnavion/k8s-openapi@0a9d7e4,
which implements a workarond for a bug in the Kubernetes Node API that
wherein empty lists are encoded as `null`. This workaround is necessary
until the Kubernetes v1.22 API is released including a change to the
OpenAPI spec in kubernetes/kubernetes#102159.

k8s-openapi has not yet released this fix to crates.io, so instead this
change uses a dependency patch to pull in the latest version from git.
@olix0r
fmt
06fa494
@olix0r
Copy link
Contributor Author

olix0r commented May 21, 2021

@clux I've marked this as a draft since these k8s-openapi changes haven't yet been released to crates.io (so we're taking a git dependency as a patch). Please let me know if there's anything I can do to be helpful moving this forward!

olix0r added a commit to olix0r/polixy that referenced this pull request May 21, 2021
@olix0r
kube: Use git dependencies
69878e8 
Picks up the changes from kube-rs/kube#531, which uses k8s-openapi from
git. The next version will workaround cases where ContainerImages::names
is null (instead of empty); and it generally replaces several unneeded
options in favor of empty values.
@olix0r olix0r mentioned this pull request May 21, 2021
Closed
@clux
Copy link
Member

clux commented May 21, 2021

This looks great to me. Thanks a lot for doing this. Super happy with how much the metadata accessor stuff got cleaned up by this.

Did a small change in master related to dynamic objects before our 0.55 release, but don't think it should affect this branch. Looking forward to merging when k8s-openapi releases it :-)

@olix0r olix0r marked this pull request as ready for review June 16, 2021 13:46
@olix0r
Copy link
Contributor Author

olix0r commented Jun 16, 2021 •
edited
Loading

@clux @kazk k8s-openapi v0.12.0 is now on crates.io. I've updated the dependencies in this PR and I think it's ready for review/merge now. Thanks!

olix0r
olix0r commented Jun 16, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@olix0r
Copy link
Contributor Author

olix0r commented Jun 16, 2021

Note that k8s-openapi v0.12.0 supports the feature v1_21 now. I haven't updated any of the dependencies/examples to use this API version though. Let me know if you'd prefer that I do that as part of this change.

@clux
Copy link
Member

clux commented Jun 16, 2021

Note that k8s-openapi v0.12.0 supports the feature v1_21 now. I haven't updated any of the dependencies/examples to use this API version though. Let me know if you'd prefer that I do that as part of this change.

That's okay, we can wait a little with using that everywhere internally.

clux
clux approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks great to me, I am happy to merge if CI passes!

@clux clux merged commit ac1fd38 into kube-rs:master Jun 16, 2021
@clux
Copy link
Member

clux commented Jun 16, 2021

Released in 0.57.0. Thanks again!

@olix0r olix0r deleted the ver/api-bump branch June 18, 2021 14:26
clux added a commit that referenced this pull request Aug 9, 2021
@clux
bump k8s-openapi 0.13.0 and revert option unpacking - fixes #581
30abcec 
reverts most of #531 while bumping k8s-openapi for https://github.com/Arnavion/k8s-openapi/releases/tag/v0.13.0

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux mentioned this pull request Aug 9, 2021
Merged
clux added a commit that referenced this pull request Aug 9, 2021
@clux
bump k8s-openapi 0.13.0 and revert option unpacking - fixes #581 (#616)
ae92f05 
* bump k8s-openapi 0.13.0 and revert option unpacking - fixes #581

reverts most of #531 while bumping k8s-openapi for https://github.com/Arnavion/k8s-openapi/releases/tag/v0.13.0

Signed-off-by: clux <sszynrae@gmail.com>

* rust upgrade needs a bump to stdout test in kube-derive

Signed-off-by: clux <sszynrae@gmail.com>

* port categories change into crd_derive test

Signed-off-by: clux <sszynrae@gmail.com>

* clippy

Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazk kazk kazk left review comments

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olix0r @clux @kazk