Change Reflector internal representation #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `Reflector` internal representation and index all the objects by both `name` and `namespace`. With the previous implementation, there were some issues with object with the same `name`, as described on: kube-rs#55 This makes the `Cache` internal and we convert the data to a `Vec` when it's read.
gnieto
commented
Aug 1, 2019
clux
approved these changes
Aug 3, 2019
| namespace: object_meta.namespace.clone(), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a nice place to hide this complexity. Nice use of traits on ObjectId 👍
|
I think this is great for now. It definitely resolves the main problem, and it makes the examples cleaner to use by hiding the unnecessary pair. Some better iterator support in general would be nice, but not sure how to efficiently encapsulate that when it's referring to a read-locked resource. Cloning and moving feels acceptable since rust's fast at compute, and a reflector is mostly waiting for IO anyway. PRs are of course welcome though 🙂 |
This was referenced Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Reflectorinternal representation and index all the objects byboth
nameandnamespace. With the previous implementation, therewere some issues with object with the same
name, as described on:#55
This makes the
Cacheinternal and we convert the data to aVecwhenit's read.
I think that this implementation combines the 2 ideas we discussed on the issue. Even that, I'm not convinced about returning a
Vec. I was thinking about returning an iterator, but I would need to think about it a little bit more. What do you think?