Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add missing reason to Display on Error::Validation in Request #798

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

clux
Copy link
Member

@clux clux commented Jan 28, 2022

fixes #777

@clux clux added this to the 0.68.0 milestone Jan 28, 2022
@clux clux requested a review from kazk January 28, 2022 10:12
@clux clux added changelog-fix changelog fix category for prs core generic apimachinery style work errors error handling or error ergonomics labels Jan 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #798 (ae55ed0) into master (93fcff3) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   71.75%   71.92%   +0.16%     
==========================================
  Files          56       56              
  Lines        3770     3775       +5     
==========================================
+ Hits         2705     2715      +10     
+ Misses       1065     1060       -5     
Impacted Files Coverage Δ
kube-core/src/request.rs 95.84% <100.00%> (+0.84%) ⬆️
kube-core/src/params.rs 71.02% <0.00%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93fcff3...ae55ed0. Read the comment docs.

@clux clux merged commit 3381e69 into master Jan 28, 2022
@clux clux deleted the val-error branch January 28, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs core generic apimachinery style work errors error handling or error ergonomics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kube-core] Validation error should show detail error message
3 participants