Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer kubeconfig over in-cluster config #823

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Prefer kubeconfig over in-cluster config #823

merged 1 commit into from
Feb 11, 2022

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 11, 2022

Fixes #818

@nightkr
Prefer kubeconfig over in-cluster config
67474cd 
Fixes kube-rs#818

Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
@nightkr nightkr added config Kube config related changelog-change changelog change category for prs labels Feb 11, 2022
@nightkr nightkr requested a review from a team February 11, 2022 12:43
@nightkr nightkr self-assigned this Feb 11, 2022
@nightkr nightkr added the bug Something isn't working label Feb 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #823 (67474cd) into master (465497c) will decrease coverage by 0.13%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
- Coverage   70.05%   69.92%   -0.14%     
==========================================
  Files          58       58              
  Lines        3984     3983       -1     
==========================================
- Hits         2791     2785       -6     
- Misses       1193     1198       +5
Impacted Files Coverage Δ
kube-client/src/config/mod.rs 50.00% <14.28%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465497c...67474cd. Read the comment docs.

clux
clux approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nightkr nightkr merged commit 8b5cb03 into kube-rs:master Feb 11, 2022
@nightkr nightkr deleted the bugfix/prefer-kubeconfig branch February 11, 2022 13:02
@kazk kazk mentioned this pull request Feb 13, 2022
Merged
@clux clux added this to the 0.69.0 milestone Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees

@nightkr nightkr

Labels
bug Something isn't working changelog-change changelog change category for prs config Kube config related
Projects
None yet
Milestone
0.69.0
Development

Successfully merging this pull request may close these issues.

Kube-rs config inference doesn't match kubectl
3 participants
@nightkr @codecov-commenter @clux