-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid CRD when Enum variants have descriptions #852
Conversation
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Many thanks for your review @teozkr! |
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
fe0cc60
to
2d56b21
Compare
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 70.22% 70.27% +0.05%
==========================================
Files 59 59
Lines 4215 4226 +11
==========================================
+ Hits 2960 2970 +10
- Misses 1255 1256 +1
Continue to review full report at Codecov.
|
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
99348f9
to
10cfc4b
Compare
## Description Bump kube to 0.70.0 for bugfix kube-rs/kube#852. As this is a braking change I've updated to a new minor version.
Motivation
I would like to document the different enum variants of my CRDs with Rust doc. By doing so a description attribute should be added to the CRD enum variants. Currently placing an description on an enum variant produces an invalid CRD.
Solution
This PR fixes the problem by moving the description attribute to the correct location inside the CRD schema.
Details can be found in the code comments.
Signed-off-by: Sebastian Bernauer sebastian.bernauer@stackable.de