Make remote commands cancellable and remove panics #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
==========================================
- Coverage 70.66% 70.62% -0.05%
==========================================
Files 61 61
Lines 4255 4241 -14
==========================================
- Hits 3007 2995 -12
+ Misses 1248 1246 -2
|
clux
approved these changes
Mar 31, 2022
Signed-off-by: kazk <kazk.dev@gmail.com>
kazk
force-pushed
the
refine-remote-command
branch
from
938f925
to
3918057
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make remote commands (
attach,exec) cancellable like portforward (#854). Also addErrorand remove panics.