Admission controller example fixes #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on script showing necessary steps when running behind a service. Fixes kube-rs#944 Signed-off-by: Alicrow <writerofalicrow@gmail.com>
…s field if it doesn't already exist. Fixes kube-rs#943 Signed-off-by: Alicrow <writerofalicrow@gmail.com>
clux
approved these changes
Jul 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
=======================================
Coverage 72.43% 72.43%
=======================================
Files 64 64
Lines 4412 4412
=======================================
Hits 3196 3196
Misses 1216 1216 |
Signed-off-by: Alicrow <writerofalicrow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #943 and #944
Solution
Added commented-out code to certificate setup script for adding DNS name to certificate.
Added check around adding /metadata/labels to only add the field if it doesn't already exist.