Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate finalizers race condition #965

Merged
merged 3 commits into from
Jul 28, 2022
Merged

fix duplicate finalizers race condition #965

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c11a645
fix duplicate finalizers race condition
alex-hunt-materialize Jul 27, 2022
0c95615
Add comment about why we test finalizers haven't changed
alex-hunt-materialize Jul 28, 2022
28b84d9
just fmt
alex-hunt-materialize Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions kube-runtime/src/finalizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,19 @@ where
}),
]
} else {
vec![PatchOperation::Add(AddOperation {
path: "/metadata/finalizers/-".to_string(),
value: finalizer_name.into(),
})]
vec![
// Kubernetes doesn't automatically deduplicate finalizers (see
// https://github.com/kube-rs/kube-rs/issues/964#issuecomment-1197311254),
// so we need to fail and retry if anyone else has added the finalizer in the meantime
PatchOperation::Test(TestOperation {
path: "/metadata/finalizers".to_string(),
value: obj.finalizers().into(),
}),
PatchOperation::Add(AddOperation {
path: "/metadata/finalizers/-".to_string(),
value: finalizer_name.into(),
}),
]
});
api.patch::<K>(
obj.meta().name.as_deref().ok_or(Error::UnnamedObject)?,
Expand Down