-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enforcer(bpf): automatically mount bpffs #1097
enforcer(bpf): automatically mount bpffs #1097
Conversation
bbf3321
to
a902510
Compare
Update - Cilium too uses a privileged init Mount-bpf container for bidirectional mounting and the cilium-agent is unprivileged by default but may be privileged if specified through helm values. Mount-bpf does the mounting work when Cilium is running in K8s. However the logic we've implemented now would create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Please check for review comment inline.
a902510
to
bafc2a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor nit
Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com>
bafc2a3
to
2b8bf35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!. Needs to be tested on AZL2 before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested on AL2. Good to merge. |
Signed-off-by: Rudraksh Pareek rudraksh@accuknox.comPurpose of PR?:
May fix #1005
Does this PR introduce a breaking change?
Nope
If the changes in this PR are manually verified, list down the scenarios covered::
umount /sys/fs/bpf
) - kubearmor-init now mounts it when deployedAdditional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Though
SYS_ADMIN
capability should be enough for mounting filesystems but bpffs needs the container to be privileged.Checklist:
<type>(<scope>): <subject>