-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gRPC): Implement m-TLS Support using self-signed certificate #1526
Conversation
f2a6b60
to
4677704
Compare
4677704
to
d428878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Looks good to me, Can you please add the steps to test this PR.
eb03833
to
4cb41b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general.
Small question/comment.
Can we include high level flow diagram of how the certificates are going to be generated, used and verified across KubeArmor and KubeArmor clients/relay
4cb41b1
to
9bb8e13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: rksharma95 <ramakant@accuknox.com>
9bb8e13
to
c2d28d2
Compare
Purpose of PR?:
This PR introduces m-TLS support using self-signed certificate to secure KubeArmor gRPC endpoint. with the tls encryption we ensure secure communication between the KubeArmor server and the clients i.e. kubearmor-relay.
Fixes #1464
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>