Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): add go-get-tool function in makefile of KubeArmorOperator #1699

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(build): add go-get-tool function in makefile of KubeArmorOperator #1699

merged 1 commit into from
Jan 10, 2025
+9 −0

Conversation

Affan-7
Copy link
Contributor

@Affan-7 Affan-7 commented Mar 20, 2024 •
edited
Loading

Purpose of PR?:

Add a handy go-get-tool function to install go packages.

Fixes #1609

Does this PR introduce a breaking change?
No

Checklist:

  • Bug fix. Fixes Operator MakeFile target throwing errors during binary installation. #1609
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Screenshot:

image

@Affan-7
Copy link
Contributor Author

Affan-7 commented Mar 20, 2024

CC: @rootxrishabh

rootxrishabh
rootxrishabh approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@rootxrishabh rootxrishabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daemon1024 daemon1024 force-pushed the makefile-go-get-tool branch 2 times, most recently from b8fed40 to dfc4a2c Compare April 19, 2024 10:30
@kranurag7 kranurag7 force-pushed the makefile-go-get-tool branch from dfc4a2c to 4c3bc7f Compare May 1, 2024 07:32
@daemon1024 daemon1024 force-pushed the makefile-go-get-tool branch from 4c3bc7f to dd72211 Compare January 9, 2025 06:29
@Affan-7 @daemon1024
Add go-get-tool function in makefile of KubeArmorOperator
004ef4c 
Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
@daemon1024 daemon1024 force-pushed the makefile-go-get-tool branch from dd72211 to 004ef4c Compare January 9, 2025 19:25
@daemon1024 daemon1024 merged commit ca59e4a into kubearmor:main Jan 10, 2025
18 checks passed
@Affan-7 Affan-7 deleted the makefile-go-get-tool branch January 11, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daemon1024 daemon1024 daemon1024 approved these changes

@rootxrishabh rootxrishabh rootxrishabh approved these changes

@DelusionalOptimist DelusionalOptimist Awaiting requested review from DelusionalOptimist

Assignees
No one assigned
Labels
None yet
Projects
Release v1.5
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operator MakeFile target throwing errors during binary installation.
3 participants
@Affan-7 @daemon1024 @rootxrishabh